Re: misc/50166

[Antti Kantee <pooka%NetBSD.org@localhost>]

The following reply was made to PR misc/50166; it has been noted by GNATS.

From: Antti Kantee <pooka%NetBSD.org@localhost>
To: Robert Millan <rmh%gnu.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, misc-bug-people%netbsd.org@localhost,
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: misc/50166
Date: Sun, 20 Sep 2015 12:48:21 +0000

 On 20/09/15 12:20, Robert Millan wrote:
 >>> what is the expected include path for arch.c -> compat_defs.h?
 >>
 >> Try adding:
 >>
 >> #if HAVE_NBTOOL_CONFIG_H
 >> #include "nbtool_config.h"
 >> #endif
 >>
 >> to the appropriate place(s).
 >
 > I don't think this can work. Looking at the log, make is initially
 > compiled before running
 > build.sh, then build.sh uses make to build other stuff, and then
 > nbtool_config.h is
 > dynamically generated by src/tools/compat/configure.
 >
 > Can we make an exception for make and put the MAXPATHLEN ifdef in make.h
 > too?
 
 You don't think it can work, or you tested it => it didn't work, and you 
 think there's a fundamental flaw in the scheme?
 
 We can address make separately too if need be.  Do you still need the 
 bits in compat/{Makefile,defs.mk.in}?  Can those be addressed by using 
 compat_defs.h instead of hardcoding the values based on uname -s?  Or 
 does that require including nbtool_config.h from a large number of .c files?