Re: bin/50255 (Remove unused flag from acpidump.c and acpidump.8)

[henning petersen <henning.petersen%t-online.de@localhost>]

The following reply was made to PR bin/50255; it has been noted by GNATS.

From: henning petersen <henning.petersen%t-online.de@localhost>
To: gnats-bugs%NetBSD.org@localhost, gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Cc: 
Subject: Re: bin/50255 (Remove unused flag from acpidump.c and acpidump.8)
Date: Sun, 20 Sep 2015 08:12:28 +0200

 This is a multi-part message in MIME format.
 --------------080405070107070400090700
 Content-Type: text/plain; charset=iso-8859-15; format=flowed
 Content-Transfer-Encoding: 7bit
 
 
 
 Am 19.09.2015 um 23:50 schrieb Thomas Klausner:
 > The following reply was made to PR bin/50255; it has been noted by GNATS.
 >
 > From: Thomas Klausner <wiz%NetBSD.org@localhost>
 > To: gnats-bugs%NetBSD.org@localhost
 > Cc:
 > Subject: Re: bin/50255 (Remove unused flag from acpidump.c and acpidump.8)
 > Date: Sat, 19 Sep 2015 23:49:37 +0200
 >
 >   On Sat, Sep 19, 2015 at 09:35:01PM +0000, henning petersen wrote:
 >   >  yes, sflag should also be removed in acpi.c and acpidump.h.
 >   >  Try to start acpidump with -s.
 >
 >   It gives me an error that it doesn't know an 's' option. But perhaps
 >   the proper fix is to add '-s' to the getopt string instead?
 >    Thomas
 >
 >
 You are right in version 1.4 acpidump.c sflag is added, but s is missing 
 in getopt.
 
 --------------080405070107070400090700
 Content-Type: text/plain; charset=UTF-8;
  name="acpidump.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="acpidump.c.diff"
 
 diff -u -p -r1.5 acpidump.c
 --- usr.sbin/acpitools/acpidump/acpidump.c	29 Aug 2011 20:38:54 -0000	1.5
 +++ usr.sbin/acpitools/acpidump/acpidump.c	20 Sep 2015 06:01:38 -0000
 @@ -72,7 +72,7 @@ main(int argc, char *argv[])
  	if (argc < 2)
  		usage();
  
 -	while ((c = getopt(argc, argv, "cdhtvf:o:")) != -1) {
 +	while ((c = getopt(argc, argv, "cdhstvf:o:")) != -1) {
  		switch (c) {
  		case 'c':
  			cflag = 1;
 
 --------------080405070107070400090700--