Re: kern/50206: panic: mii_anar -- setting media for alc(4)

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2015/09/05 4:50, matthew green wrote:
> The following reply was made to PR kern/50206; it has been noted by GNATS.
> 
> From: matthew green <mrg%eterna.com.au@localhost>
> To: Masanobu SAITOH <msaitoh%execsw.org@localhost>
> Cc: gnats-bugs%NetBSD.org@localhost, kern-bug-people%netbsd.org@localhost,
>      gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
> Subject: re: kern/50206: panic: mii_anar -- setting media for alc(4)
> Date: Sat, 05 Sep 2015 05:45:34 +1000
> 
>   >  Could you try with the following diff?
>   > I have no any atphy(4) device.
>   >
>   > Index: atphy.c
>   > ===================================================================
>   > RCS file: /cvsroot/src/sys/dev/mii/atphy.c,v
>   > retrieving revision 1.16
>   > diff -u -r1.16 atphy.c
>   > --- atphy.c	16 Jun 2014 12:36:41 -0000	1.16
>   > +++ atphy.c	4 Sep 2015 10:26:43 -0000
>   > @@ -228,7 +228,7 @@
>   >  			return EINVAL;
>   >  		}
>   >
>   > -		anar = mii_anar(ife->ifm_media);
>   > +		anar = mii_anar(IFM_SUBTYPE(ife->ifm_media));
>   >  		if (((ife->ifm_media & IFM_GMASK) & IFM_FDX) != 0) {
>   >  			bmcr |= BMCR_FDX;
>   >  			/* Enable pause. */
>   
>   thanks.
>   
>   this stops the panic, but my alc(4) is dead in the water after
>   i've set any media it seems.  aah, after setting back to
>   "autoselect" it does eventually regain the link (though this
>   takes a good 20+ seconds.)
>   
>   so, this patch helps the original PR.  please commit it and i
>   will file a PR on the new issues :)

 Done and will be pulled up to netbsd-[567]

>   
>   .mrg.
>   
> 


-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)