Re: kern/50206: panic: mii_anar -- setting media for alc(4)

[Masanobu SAITOH <msaitoh%execsw.org@localhost>]

On 2015/09/04 18:45, mrg%eterna.com.au@localhost wrote:
>> Number:         50206
>> Category:       kern
>> Synopsis:       panic: mii_anar -- setting media for alc(4)
>> Confidential:   no
>> Severity:       serious
>> Priority:       medium
>> Responsible:    kern-bug-people
>> State:          open
>> Class:          sw-bug
>> Submitter-Id:   net
>> Arrival-Date:   Fri Sep 04 09:45:00 +0000 2015
>> Originator:     matthew green
>> Release:        NetBSD 7.99.21
>> Organization:
> people's front against (bozotic) www (softwar foundation)
>> Environment:
> System: NetBSD splode.eterna.com.au 6.1_STABLE NetBSD 6.1_STABLE (_splode_) #3: Sun Jul 26 21:53:08 EST 2015 mrg%splode.eterna.com.au@localhost:/var/obj/sparc64/usr/src/sys/arch/sparc64/compile/_splode_ sparc64
> Architecture: sparc64
> Machine: sparc64
> 
> 	actually my kernel is an amd64 laptop, the above is my send-pr host.
> 
>> Description:
> 
> 	i installed -current kernel on an asus laptop with a recent alc(4)
> 	chipset:
> 
> 	alc0 at pci3 dev 0 function 0: Atheros AR8162 PCIe Fast Ethernet
> 	alc0: interrupting at ioapic0 pin 19
> 	atphy0 at alc0 phy 0: Atheros AR8035 10/100/1000 PHY, rev. 9
> 
> 	i tried to run "ifconfig alc0 media 100baseTX mediaopt full-duplex"
> 	and i got the following panic:
> 
> 	System panicked: mii_anar
> 	Backtrace from time of crash is available.
> 	crash> bt
> 	_KERNEL_OPT_NVGA_RASTERCONSOLE() at 0
> 	?() at fffffe807864fdd8
> 	panic() at panic
> 	snprintf() at snprintf
> 	mii_anar() at mii_anar+0x17
> 	atphy_service() at atphy_service+0x134
> 	mii_mediachg() at mii_mediachg+0x31
> 	ifmedia_ioctl() at ifmedia_ioctl+0x96
> 	alc_ioctl() at alc_ioctl+0x3a
> 	doifioctl() at doifioctl+0x56e
> 	soo_ioctl() at soo_ioctl+0x23e
> 	sys_ioctl() at sys_ioctl+0x253
> 	syscall() at syscall+0xd2
> 	--- syscall (number 54) ---
> 	7f7ff6ccf7ba:
> 
>> How-To-Repeat:
>> Fix:
> 

 Could you try with the following diff?
I have no any atphy(4) device.

Index: atphy.c
===================================================================
RCS file: /cvsroot/src/sys/dev/mii/atphy.c,v
retrieving revision 1.16
diff -u -r1.16 atphy.c
--- atphy.c	16 Jun 2014 12:36:41 -0000	1.16
+++ atphy.c	4 Sep 2015 10:26:43 -0000
@@ -228,7 +228,7 @@
 			return EINVAL;
 		}
 
-		anar = mii_anar(ife->ifm_media);
+		anar = mii_anar(IFM_SUBTYPE(ife->ifm_media));
 		if (((ife->ifm_media & IFM_GMASK) & IFM_FDX) != 0) {
 			bmcr |= BMCR_FDX;
 			/* Enable pause. */



-- 
-----------------------------------------------
                SAITOH Masanobu (msaitoh%execsw.org@localhost
                                 msaitoh%netbsd.org@localhost)