install/49870: postinstall script skipping fontconfig check

[vchaves%ymail.com@localhost]

>Number:         49870
>Category:       install
>Synopsis:       postinstall script skipping fontconfig check
>Confidential:   no
>Severity:       critical
>Priority:       high
>Responsible:    install-manager
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat May 02 18:30:00 +0000 2015
>Originator:     Vicente Chaves
>Release:        NetBSD 7.0_BETA
>Organization:
>Environment:
System: NetBSD netbsd7.vbox.lab 7.0_BETA NetBSD 7.0_BETA (GENERIC) #1: Sat May 2 02:57:33 UTC 2015 vchaves%netbsd7.vbox.lab@localhost:/home/vchaves/netbsd-7/src/sys/arch/amd64/compile/obj/GENERIC amd64
Architecture: x86_64
Machine: amd64
>Description:
At the end of the ./build.sh -U -x install =/  the postinstall script searches for X11 sources in /usr/xsrc despite receiving the -s option correctly.


postinstall-check ===> .        (with: DESTDIR=/)
   === Post installation checks ===
AWK=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbawk               DB=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbdb                        HOST_SH=/bin/sh                 MAKE=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbmake                    PWD_MKDB=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbpwd_mkdb    SED=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbsed              STAT=/home/vchaves/netbsd-7/src/obj/tooldir.NetBSD-7.0_BETA-amd64/bin/nbstat /bin/sh /home/vchaves/netbsd-7/src/usr.sbin/postinstall/postinstall  -m amd64 -a x86_64 -s /home/vchaves/netbsd-7/src -d // check; if [ $? -gt 1 ]; then exit 1; fi
Source directory: /home/vchaves/netbsd-7/src
Target directory: //
bluetooth check:
ddbonpanic check:
defaults check:
        /tmp/_postinstall.17194.0/defaults/rc.conf != ///etc/defaults/rc.conf
dhcpcd check:
dhcpcdrundir check:
envsys check:
fontconfig check:
        /usr/src/../xsrc/external/mit/fontconfig/dist/conf.d is not a directory; skipping check
gid check:
gpio check:
hosts check:
iscsi check:
makedev check:
motd check:
eval: cannot open /home/vchaves/netbsd-7/src/etc/motd: no such file
        Bug reporting messages do not seem to match the installed release
mtree check:
        /tmp/_postinstall.17194.0/NetBSD.dist != ///etc/mtree/NetBSD.dist
named check:
pam check:
periodic check:
pf check:
pwd_mkdb check:
rc check:
ssh check:
wscons check:
x11 check:
xkb check:
uid check:
varrwho check:
tcpdumpchroot check:
atf check:
catpages check:
ptyfsoldnodes check:
        Remove legacy device node ///dev/ptyp0
        Remove legacy device node ///dev/ptyp1
        Remove legacy device node ///dev/ttyp0
        Remove legacy device node ///dev/ttyp1
varshm check:
obsolete check:
        Remove obsolete file ///lib/libc.so.12.193
        Remove obsolete link ///usr/lib/libc.so.12.193
        Remove obsolete file ///usr/lib/i386/libc.so.12.193
postinstall checks passed: bluetooth ddbonpanic dhcpcd dhcpcdrundir envsys fontconfig gid gpio hosts iscsi makedev named pam periodic pf pwd_mkdb rc ssh wscons x11 xkb uid varrwho tcpdumpchroot atf catpages varshm
postinstall checks failed: defaults motd mtree ptyfsoldnodes obsolete
To fix, run:
    /bin/sh /home/vchaves/netbsd-7/src/usr.sbin/postinstall/postinstall -s /home/vchaves/netbsd-7/src -d // fix defaults motd mtree ptyfsoldnodes obsolete
Note that this may overwrite local changes.
 
>How-To-Repeat:
Try installing the distribution with ./build.sh -U -x install=/ , and the sources are not in their default location.
>Fix:
the following patch worked for me

cvs diff: Diffing usr.sbin/postinstall
Index: usr.sbin/postinstall/postinstall
===================================================================
RCS file: /cvsroot/src/usr.sbin/postinstall/postinstall,v
retrieving revision 1.175.2.4
diff -r1.175.2.4 postinstall
2115d2114
<       XSRC_DIR="${SRC_ARG}/../xsrc"
2211a2211,2214
>       if [ -z "${XSRC_DIR}" ]; then
>               XSRC_DIR="${SRC_DIR}/../xsrc"
>       fi
>