Re: PR/49683

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR lib/49683; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: gnats-bugs%NetBSD.org@localhost, lib-bug-people%netbsd.org@localhost, 
	gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost, amirpli%gmail.com@localhost
Cc: 
Subject: Re: PR/49683
Date: Sat, 21 Feb 2015 21:16:35 -0500

 On Feb 22,  2:00am, amirpli%gmail.com@localhost (Amir P) wrote:
 -- Subject: Re: PR/49683
 
 |  A question:
 |  
 |  The actual change that has been implemented in chartype.c rev. 1.11 is:
 |  
 |  if (conv->csize < ++len)
 |  if (ct_conv_buff_resize(conv, (size_t)0, len + CT_BUFSIZ) == -1)
 |  return NULL;
 |  
 |  Please clarify - we need to enlarge conv->wbuff in case its size
 |  conv->wsize is less than len+1.
 |  So why does the check above compare len+1 to conv->csize, which is not
 |  related to the size of conv->wbuff?
 
 It is wrong, I've split the functions.
 
 christos