bin/49658: Wrong comparsion in pflogd.c

[henning.petersen%t-online.de@localhost]

>Number:         49658
>Category:       bin
>Synopsis:       Wrong comparsion in pflogd.c
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Feb 12 09:30:00 +0000 2015
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
wrong comparsion in pflogd function if_exists is returning 0 or 1.
>How-To-Repeat:

>Fix:
diff -u -p -r1.9 pflogd.c
--- dist/pf/sbin/pflogd/pflogd.c	29 Feb 2012 23:42:28 -0000	1.9
+++ dist/pf/sbin/pflogd/pflogd.c	12 Feb 2015 08:46:28 -0000
@@ -729,7 +729,7 @@ main(int argc, char **argv)
 		np = pcap_dispatch(hpcap, PCAP_NUM_PKTS,
 		    phandler, (u_char *)dpcap);
 		if (np < 0) {
-			if (!if_exists(interface) == -1) {
+			if (!if_exists(interface)) {
 				logmsg(LOG_NOTICE, "interface %s went away",
 				    interface);
 				ret = -1;