Re: port-arm/49621: Add detach function to if_cpsw

[christos%zoulas.com@localhost (Christos Zoulas)]

On Feb 1,  7:05pm, webpages%sprow.co.uk@localhost (Robert Sprowson) wrote:
-- Subject: Re: port-arm/49621: Add detach function to if_cpsw

| The following reply was made to PR port-arm/49621; it has been noted by GNATS.
| 
| From: Robert Sprowson <webpages%sprow.co.uk@localhost>
| To: gnats-bugs%NetBSD.org@localhost
| Cc: port-arm-maintainer%netbsd.org@localhost,
| 	gnats-admin%netbsd.org@localhost,
| 	netbsd-bugs%netbsd.org@localhost
| Subject: Re: port-arm/49621: Add detach function to if_cpsw
| Date: Sun, 01 Feb 2015 19:00:58 +0000 (GMT)
| 
|  > Doesn't it need to do at least a bus_space_unmap(), call cpsw_stop()
|  > and do all the other interface cleanup that the other drivers do
|  > when detaching?
|  
|  You're quite right, I'd only been considering the equivalents of
|  malloc/free, but cpsw_match has other (non allocating) side effects. This
|  updated patch should address those too, inspired by the i82577 driver:

Much better now! I've committed it, with a couple of changes to make it
safer...

Thanks!

christos