Re: port-arm/49299: earmv7hfeb kernels can not load modules

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR port-arm/49299; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Martin Husemann <martin%duskware.de@localhost>
Cc: "gnats-bugs%NetBSD.org@localhost" <gnats-bugs%NetBSD.org@localhost>
Subject: Re: port-arm/49299: earmv7hfeb kernels can not load modules
Date: Fri, 7 Nov 2014 07:49:57 -0500

 On Nov 7,  8:48am, martin%duskware.de@localhost (Martin Husemann) wrote:
 -- Subject: Re: port-arm/49299: earmv7hfeb kernels can not load modules
 
 | On Thu, Nov 06, 2014 at 06:49:02PM -0500, Christos Zoulas wrote:
 | > This sequence of strcmps can be made a lot more efficient with specialized code (and smaller)
 | 
 | Yes, not sure it is worth though, but can do.
 | 
 | > > +        case ThumbStart:
 | > > +            p16 = (uint16_t*)list->markers[i].addr;
 | > > +            p16_end = (uint16_t*)va_end;
 | > > +            if (i+1 < list->cnt) {
 | > > +                if ((uintptr_t)list->markers[i+1].addr
 | > > +                    < va_end)
 | > > +                    p16_end = (uint16_t*)
 | > > +                        list->markers[i+1].addr;
 | > > +        
 | > 
 | > I think a default and break here is better
 | 
 | Sorry, I don't understand what you mean.
 
 There is a switch statement and there is no break and default: after the last
 case statement.
 
 christos