Re: port-arm/49299: earmv7hfeb kernels can not load modules

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR port-arm/49299; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: Christos Zoulas <christos%zoulas.com@localhost>
Cc: "gnats-bugs%NetBSD.org@localhost" <gnats-bugs%NetBSD.org@localhost>
Subject: Re: port-arm/49299: earmv7hfeb kernels can not load modules
Date: Fri, 7 Nov 2014 08:48:17 +0100

 On Thu, Nov 06, 2014 at 06:49:02PM -0500, Christos Zoulas wrote:
 > This sequence of strcmps can be made a lot more efficient with specialized code (and smaller)
 
 Yes, not sure it is worth though, but can do.
 
 > > +        case ThumbStart:
 > > +            p16 = (uint16_t*)list->markers[i].addr;
 > > +            p16_end = (uint16_t*)va_end;
 > > +            if (i+1 < list->cnt) {
 > > +                if ((uintptr_t)list->markers[i+1].addr
 > > +                    < va_end)
 > > +                    p16_end = (uint16_t*)
 > > +                        list->markers[i+1].addr;
 > > +        
 > 
 > I think a default and break here is better
 
 Sorry, I don't understand what you mean.
 
 Martin