Re: misc/49356: atf-c/config.h has been removed in ATF v0.2.1; several tests reference the header

[Justin Cormack <justin%specialbusservice.com@localhost>]

On Mon, Nov 3, 2014 at 9:00 PM,  <yaneurabeya%gmail.com@localhost> wrote:
>>Number:         49356
>>Category:       misc
>>Synopsis:       atf-c/config.h has been removed in ATF v0.2.1; several tests reference the header
>>Confidential:   no
>>Severity:       non-critical
>>Priority:       low
>>Responsible:    misc-bug-people
>>State:          open
>>Class:          sw-bug
>>Submitter-Id:   net
>>Arrival-Date:   Mon Nov 03 21:00:00 +0000 2014
>>Originator:     Garrett Cooper
>>Release:        n/a
>>Organization:
> EMC / Isilon Storage Division
>>Environment:
> n/a
>>Description:
> A recent update by jmmv@ to ATF 0.2.1 removed atf-c/config.h installation on FreeBSD:
> https://svnweb.freebsd.org/base/head/lib/atf/libatf-c/Makefile?limit_changes=0&r1=273929&r2=273928&pathrev=273929
>
> Several of the NetBSD testcases that have been ported to FreeBSD still reference the header:
>
> $ grep -r atf-c/config.h tests/
> tests/include/t_paths.c:#include <atf-c/config.h>
> tests/lib/libc/gen/t_fpsetmask.c:#include <atf-c/config.h>
> tests/lib/libc/gen/t_isnan.c:#include <atf-c/config.h>
> tests/lib/libc/gen/t_siginfo.c:#include <atf-c/config.h>
> tests/lib/libc/gen/t_floatunditf.c:#include <atf-c/config.h>
> tests/lib/libc/gen/.#t_siginfo.c.1.20:#include <atf-c/config.h>
> tests/lib/libc/stdlib/t_strtod.c:#include <atf-c/config.h>
> tests/lib/libc/sys/t_sigaction.c:#include <atf-c/config.h>
> tests/lib/libexecinfo/t_backtrace.c:#include <atf-c/config.h>
> tests/lib/libm/t_ldexp.c:#include <atf-c/config.h>
> tests/lib/libm/t_log.c:#include <atf-c/config.h>
> tests/lib/libm/t_precision.c:#include <atf-c/config.h>
> tests/lib/libpthread/t_mutex.c:#include <atf-c/config.h>
> tests/lib/libpthread/t_sem.c:#include <atf-c/config.h>
>
>>How-To-Repeat:
> Attempt to upgrade ATF to v0.2.1 in a manner similar to the above commit to FreeBSD.
>>Fix:

Well it does not look very necessary, as it only has a prototype that
is not actually used anywhere, so will look at removing these includes
so we can upgrade...

Justin