kern/49289: bogus kernel printf in scsi inquire

[martin%NetBSD.org@localhost]

>Number:         49289
>Category:       kern
>Synopsis:       bogus kernel printf in scsi inquire
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Thu Oct 16 08:50:00 +0000 2014
>Originator:     Martin Husemann
>Release:        NetBSD 7.99.1
>Organization:
The NetBSD Foundation, Inc.
>Environment:
System: NetBSD whoever-brings-the-night.aprisoft.de 7.99.1 NetBSD 7.99.1 (WHOEVER) #17: Thu Oct 9 09:59:02 CEST 2014 martin%seven-days-to-the-wolves.aprisoft.de@localhost:/usr/src/sys/arch/sparc64/compile/WHOEVER sparc64
Architecture: sparc64
Machine: sparc64
>Description:

Revision 1.161 of src/sys/dev/scsipi/scsipi_base.c added a bogus printf:

#if 0
printf("inquire: error=%d\n", error);
#endif
#if 1
            } else {
printf("inquire: addlen=%d, not retrying\n", inqbuf->additional_length);
#endif

This looks like a left over debug message - at least it is useless to the
normal user. It should be reworded or simply removed.

It triggers for me on various machines with real scsi disks:

mpt0 at pci1 dev 4 function 0: Symbios Logic 53c1020/53c1030 (rev. 0x07)
mpt0: applying 1030 quirk
mpt0: interrupting at ivec 1f69
scsibus0 at mpt0: 16 targets, 8 luns per target
[..]
inquire: addlen=139, not retrying
sd0 at scsibus0 target 0 lun 0: <SEAGATE, ST373207LSUN72G, 045A> disk fixed
sd0: 70007 MB, 14089 cyl, 24 head, 424 sec, 512 bytes/sect x 143374738 sectors
dk0 at sd0: sb2k5Root/a
dk0: 93008640 blocks at 0, type: ffs

or:

esiop0 at pci2 dev 2 function 0: Symbios Logic 53c1010-66 (ultra3-wide scsi)
esiop0: using on-board RAM
esiop0: interrupting at ivec 1f29
scsibus0 at esiop0: 16 targets, 8 luns per target
[..]
inquire: addlen=139, not retrying
sd0 at scsibus0 target 0 lun 0: <SEAGATE, ST336607LSUN36G, 0307> disk fixed
sd0: 34732 MB, 24622 cyl, 27 head, 107 sec, 512 bytes/sect x 71132959 sectors
inquire: addlen=139, not retrying
sd0: sync (25.00ns offset 31), 16-bit (80.000MB/s) transfers, tagged queueing
inquire: addlen=139, not retrying
sd1 at scsibus0 target 1 lun 0: <SEAGATE, ST336607LSUN36G, 0307> disk fixed
sd1: 34732 MB, 24622 cyl, 27 head, 107 sec, 512 bytes/sect x 71132959 sectors
inquire: addlen=139, not retrying
sd1: sync (25.00ns offset 31), 16-bit (80.000MB/s) transfers, tagged queueing


>How-To-Repeat:
Boot -current on a machine with SCSI disks.

>Fix:
Turn off the message?