Re: bin/48874

[rudolf <netbsd%eq.cz@localhost>]

The following reply was made to PR bin/48874; it has been noted by GNATS.

From: rudolf <netbsd%eq.cz@localhost>
To: miwarin%gmail.com@localhost, Christos Zoulas <christos%netbsd.org@localhost>
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: bin/48874
Date: Tue, 14 Oct 2014 12:51:51 +0200

 This is a multi-part message in MIME format.
 --------------030409080902050809040708
 Content-Type: text/plain; charset=UTF-8; format=flowed
 Content-Transfer-Encoding: 8bit
 
 ä¸?輪æ??( Miwa Susumu ) wrote:
 >   It is because going through auth.c allowed_user() .
 >
 >   crypto/external/bsd/openssh/dist/auth.c
 >
 >     allowed_user(struct passwd * pw)
 >       hostname = get_canonical_hostname(1);  <===
 >
 >   allowed_user() is different between NetBSD and OpenSSH (original) .
 >
 >   http://cvsweb.openbsd.org/cgi-bin/cvsweb/src/usr.bin/ssh/auth.c
 >
 >   I do not know why.
 
 Hi, thank you for looking into this.
 
 Christos, is there a reason NetBSD is using here 
 "get_canonical_hostname(1)" instead of 
 "get_canonical_hostname(options.use_dns)"? If not, the attached patch 
 gets us the right behavior.
 
 Thanks,
 
 r.
 
 
 --------------030409080902050809040708
 Content-Type: text/x-patch;
  name="auth.c.diff"
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment;
  filename="auth.c.diff"
 
 --- crypto/external/bsd/openssh/dist/auth.c.orig	2014-10-12 21:37:09.000000000 +0200
 +++ crypto/external/bsd/openssh/dist/auth.c	2014-10-12 21:40:26.000000000 +0200
 @@ -101,7 +101,7 @@
  		return 0;
  
  #ifdef HAVE_LOGIN_CAP
 -	hostname = get_canonical_hostname(1);
 +	hostname = get_canonical_hostname(options.use_dns);
  	ipaddr = get_remote_ipaddr();
  
  	lc = login_getclass(pw->pw_class);
 
 --------------030409080902050809040708--