[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: kern/49181: i386 Kernel compilation error (warning -> error) if no PCIBIOSVERBOSE
The following reply was made to PR kern/49181; it has been noted by GNATS.
From: Joerg Sonnenberger <joerg%britannica.bec.de@localhost>
Cc: kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost,
Subject: Re: kern/49181: i386 Kernel compilation error (warning -> error) if
Date: Mon, 8 Sep 2014 15:16:13 +0200
On Mon, Sep 08, 2014 at 01:10:13PM +0000, Alan Barrett wrote:
> I offer one of the following two patches, depending on whether or not
> it's acceptable to suppress or move the pci_conf_read call.
While it changes the on-bus behavior, we don't really handle errors here
anyway. So avoiding the time of pci_conf_read sounds like the better
> Patch 1: Mark the variable __unused in the ! PCIBIOSVERBOSE case,
> and retain the pci_conf_read call in exactly the same place.
Ignoring anything else, I would just use it conditional.
Main Index |
Thread Index |