Re: PR/49144 CVS commit: src/tests/fs/vfs

[John Nemeth <jnemeth%cue.bc.ca@localhost>]

The following reply was made to PR bin/49144; it has been noted by GNATS.

From: John Nemeth <jnemeth%cue.bc.ca@localhost>
To: gnats-bugs%NetBSD.org@localhost, gnats-admin%NetBSD.org@localhost, 
netbsd-bugs%NetBSD.org@localhost,
        gson%gson.org@localhost (Andreas Gustafsson)
Cc: 
Subject: Re: PR/49144 CVS commit: src/tests/fs/vfs
Date: Fri, 29 Aug 2014 14:02:19 -0700

 On Aug 29,  6:45pm, Martin Husemann wrote:
 }
 } The following reply was made to PR bin/49144; it has been noted by GNATS.
 } 
 } From: Martin Husemann <martin%duskware.de@localhost>
 } To: gnats-bugs%NetBSD.org@localhost
 } Cc: Andreas Gustafsson <gson%gson.org@localhost>
 } Subject: Re: PR/49144 CVS commit: src/tests/fs/vfs
 } Date: Fri, 29 Aug 2014 20:44:47 +0200
 } 
 }  Good catch!
 }  
 }  [snip]
 } 
 }  (gdb) list
 }  144                             months = year & 0x03 ? regyear : leapyear;
 
      This is also wrong.  The correct formula for computing leap
 years is year divisible 4, but if year is divisible by 100, then
 it must also be divisible by 400.  I.e. 2000 was a leap year, but
 2100 won't be.  Of course, in practice this probably doesn't matter.
 And, of course, the calendar might change again sometime in the
 next 986 years.
 
 }  145                             for (month = 0; month < 12; month++) {
 }  146                                     if (days < months[month])
 }  147                                             break;
 }  148                                     days -= months[month];
 }  149                             }
 }  150                             lastddate = ((days + 1) << DD_DAY_SHIFT)
 }  151                                 + ((month + 1) << DD_MONTH_SHIFT);
 }  
 }  
 }   ;-}
 }  
 }  Martin
 }  
 }-- End of excerpt from Martin Husemann