Re: lib/25367: arc4random state is shared across forks

[Roy Marples <roy%marples.name@localhost>]

The following reply was made to PR lib/25367; it has been noted by GNATS.

From: Roy Marples <roy%marples.name@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: apb%cequrux.com@localhost, David Laight <david%l8s.co.uk@localhost>, David 
Holland
 <dholland-bugs%netbsd.org@localhost>
Subject: Re: lib/25367: arc4random state is shared across forks
Date: Sun, 25 May 2014 08:30:35 +0100

 --=_78a787e1cccc4ca0768aab6f423d85a8
 Content-Transfer-Encoding: 7bit
 Content-Type: text/plain; charset=UTF-8;
  format=flowed
 
 Hi
 
 I bumped into this as well.
 I looked over the FreeBSD thread regarding potential speed issues and 
 despite any concerns they have actually merged the change in.
 Attached is a patch to -current which does two things.
 
 1) Re-stirs if the pid changes
 2) Re-stirs after swallowing 1600000 bytes (which also addresses 
 PR/45952)
 
 I've been running this on my laptop for a while with great success and 
 unless anyone objects I'll commit it shortly.
 
 Thanks
 
 Roy
 
 --=_78a787e1cccc4ca0768aab6f423d85a8
 Content-Transfer-Encoding: base64
 Content-Type: text/x-diff;
  name=arc4random-pid.diff
 Content-Disposition: attachment;
  filename=arc4random-pid.diff;
  size=3981
 
 PyB0ZXN0Cj8gdGVzdC5jCkluZGV4OiBnZW4vYXJjNHJhbmRvbS5jCj09PT09PT09PT09PT09PT09
 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZp
 bGU6IC9jdnNyb290L3NyYy9saWIvbGliYy9nZW4vYXJjNHJhbmRvbS5jLHYKcmV0cmlldmluZyBy
 ZXZpc2lvbiAxLjIxCmRpZmYgLXUgLXAgLXIxLjIxIGFyYzRyYW5kb20uYwotLS0gZ2VuL2FyYzRy
 YW5kb20uYwkxNyBPY3QgMjAxMyAyMzo1NjoxNyAtMDAwMAkxLjIxCisrKyBnZW4vYXJjNHJhbmRv
 bS5jCTI0IE1heSAyMDE0IDIxOjQwOjEzIC0wMDAwCkBAIC00OSwxMSArNDksMTEgQEAgX193ZWFr
 X2FsaWFzKGFyYzRyYW5kb21fdW5pZm9ybSxfYXJjNHJhbgogI2VuZGlmCiAKIHN0cnVjdCBhcmM0
 X3N0cmVhbSB7Ci0JdWludDhfdCBzdGlycmVkOwotCXVpbnQ4X3QgcGFkOwogCXVpbnQ4X3QgaTsK
 IAl1aW50OF90IGo7CiAJdWludDhfdCBzWyh1aW50OF90KX4wdSArIDF1XTsJLyogMjU2IHRvIHlv
 dSBhbmQgbWUgKi8KKwlzaXplX3QgY291bnQ7CisJcGlkX3Qgc3Rpcl9waWQ7CiAJbXV0ZXhfdCBt
 dHg7CiB9OwogCkBAIC02Nyw3ICs2Nyw3IEBAIHN0cnVjdCBhcmM0X3N0cmVhbSB7CiAJCQltdXRl
 eF91bmxvY2soJihycyktPm10eCk7ICAgICAgXAogCX0KICNlbHNlCi0jZGVmaW5lIExPQ0socnMp
 IAorI2RlZmluZSBMT0NLKHJzKQogI2RlZmluZSBVTkxPQ0socnMpCiAjZW5kaWYKIApAQCAtNzgs
 NyArNzgsNyBAQCBzdHJ1Y3QgYXJjNF9zdHJlYW0gewogI2RlZmluZSBTMjU2IFM2NCgwKSwgUzY0
 KDY0KSwgUzY0KDEyOCksIFM2NCgxOTIpCiAKIHN0YXRpYyBzdHJ1Y3QgYXJjNF9zdHJlYW0gcnMg
 PSB7IC5pID0gMHhmZiwgLmogPSAwLCAucyA9IHsgUzI1NiB9LAotCQkuc3RpcnJlZCA9IDAsIC5t
 dHggPSBNVVRFWF9JTklUSUFMSVpFUiB9OworCQkuY291bnQgPSAwLCAuc3Rpcl9waWQgPSAwLCAu
 bXR4ID0gTVVURVhfSU5JVElBTElaRVIgfTsKIAogI3VuZGVmIFMKICN1bmRlZiBTNApAQCAtODcs
 MjAgKzg3LDEwIEBAIHN0YXRpYyBzdHJ1Y3QgYXJjNF9zdHJlYW0gcnMgPSB7IC5pID0gMHgKICN1
 bmRlZiBTMjU2CiAKIHN0YXRpYyBpbmxpbmUgdm9pZCBhcmM0X2FkZHJhbmRvbShzdHJ1Y3QgYXJj
 NF9zdHJlYW0gKiwgdV9jaGFyICosIGludCk7Ci1zdGF0aWMgX19ub2lubGluZSB2b2lkIGFyYzRf
 c3RpcihzdHJ1Y3QgYXJjNF9zdHJlYW0gKik7CitzdGF0aWMgX19ub2lubGluZSB2b2lkIGFyYzRf
 c3RpcihzdHJ1Y3QgYXJjNF9zdHJlYW0gKiwgcGlkX3QpOwogc3RhdGljIGlubGluZSB1aW50OF90
 IGFyYzRfZ2V0Ynl0ZShzdHJ1Y3QgYXJjNF9zdHJlYW0gKik7CiBzdGF0aWMgaW5saW5lIHVpbnQz
 Ml90IGFyYzRfZ2V0d29yZChzdHJ1Y3QgYXJjNF9zdHJlYW0gKik7CiAKLXN0YXRpYyBpbmxpbmUg
 aW50Ci1hcmM0X2NoZWNrX2luaXQoc3RydWN0IGFyYzRfc3RyZWFtICphcykKLXsKLQlpZiAoX19w
 cmVkaWN0X3RydWUocnMuc3RpcnJlZCkpCi0JCXJldHVybiAwOwotCi0JYXJjNF9zdGlyKGFzKTsK
 LQlyZXR1cm4gMTsKLX0KLQogc3RhdGljIGlubGluZSB2b2lkCiBhcmM0X2FkZHJhbmRvbShzdHJ1
 Y3QgYXJjNF9zdHJlYW0gKmFzLCB1X2NoYXIgKmRhdCwgaW50IGRhdGxlbikKIHsKQEAgLTExNyw3
 ICsxMDcsNyBAQCBhcmM0X2FkZHJhbmRvbShzdHJ1Y3QgYXJjNF9zdHJlYW0gKmFzLCB1CiB9CiAK
 IHN0YXRpYyBfX25vaW5saW5lIHZvaWQKLWFyYzRfc3RpcihzdHJ1Y3QgYXJjNF9zdHJlYW0gKmFz
 KQorYXJjNF9zdGlyKHN0cnVjdCBhcmM0X3N0cmVhbSAqYXMsIHBpZF90IHBpZCkKIHsKIAlpbnQg
 cmRhdFszMl07CiAJaW50IG1pYltdID0geyBDVExfS0VSTiwgS0VSTl9VUk5EIH07CkBAIC0xNDYs
 MTAgKzEzNiwyNCBAQCBhcmM0X3N0aXIoc3RydWN0IGFyYzRfc3RyZWFtICphcykKIAkgKiBwYXBl
 ciAiV2Vha25lc3NlcyBpbiB0aGUgS2V5IFNjaGVkdWxpbmcgQWxnb3JpdGhtIG9mIFJDNCIKIAkg
 KiBieSBGbHVoZXIsIE1hbnRpbiwgYW5kIFNoYW1pci4gIChOID0gMjU2IGluIG91ciBjYXNlLikK
 IAkgKi8KLQlmb3IgKGogPSAwOyBqIDwgX19hcnJheWNvdW50KGFzLT5zKSAqIDQ7IGorKykKKwlm
 b3IgKGogPSAwOyBqIDwgX19hcnJheWNvdW50KGFzLT5zKSAqIHNpemVvZih1aW50MzJfdCk7IGor
 KykKIAkJYXJjNF9nZXRieXRlKGFzKTsKIAotCWFzLT5zdGlycmVkID0gMTsKKwkvKiBTdGlyIGFn
 YWluIGFmdGVyIHN3YWxsb3dpbmcgMTYwMDAwMCBieXRlcyBvciBpZiB0aGUgcGlkIGNoYW5nZXMg
 Ki8KKwlhcy0+Y291bnQgPSAxNjAwMDAwOworCWFzLT5zdGlyX3BpZCA9IHBpZDsKK30KKworc3Rh
 dGljIGlubGluZSB2b2lkCithcmM0X3N0aXJfaWZfbmVlZGVkKHN0cnVjdCBhcmM0X3N0cmVhbSAq
 YXMsIHNpemVfdCBsZW4pCit7CisJcGlkX3QgcGlkOworCisJcGlkID0gZ2V0cGlkKCk7CisJaWYg
 KGFzLT5jb3VudCA8PSBsZW4gfHwgYXMtPnN0aXJfcGlkICE9IHBpZCkKKwkJYXJjNF9zdGlyKGFz
 LCBwaWQpOworCWVsc2UKKwkJYXMtPmNvdW50IC09IGxlbjsKIH0KIAogc3RhdGljIF9faW5saW5l
 IHVpbnQ4X3QKQEAgLTE2OSw2ICsxNzMsNyBAQCBhcmM0X2dldGJ5dGVfaWooc3RydWN0IGFyYzRf
 c3RyZWFtICphcywgCiBzdGF0aWMgaW5saW5lIHVpbnQ4X3QKIGFyYzRfZ2V0Ynl0ZShzdHJ1Y3Qg
 YXJjNF9zdHJlYW0gKmFzKQogeworCiAJcmV0dXJuIGFyYzRfZ2V0Ynl0ZV9paihhcywgJmFzLT5p
 LCAmYXMtPmopOwogfQogCkBAIC0xNzYsNiArMTgxLDcgQEAgc3RhdGljIGlubGluZSB1aW50MzJf
 dAogYXJjNF9nZXR3b3JkKHN0cnVjdCBhcmM0X3N0cmVhbSAqYXMpCiB7CiAJdWludDMyX3QgdmFs
 OworCiAJdmFsID0gYXJjNF9nZXRieXRlKGFzKSA8PCAyNDsKIAl2YWwgfD0gYXJjNF9nZXRieXRl
 KGFzKSA8PCAxNjsKIAl2YWwgfD0gYXJjNF9nZXRieXRlKGFzKSA8PCA4OwpAQCAtMTg2LDE2ICsx
 OTIsMTggQEAgYXJjNF9nZXR3b3JkKHN0cnVjdCBhcmM0X3N0cmVhbSAqYXMpCiB2b2lkCiBhcmM0
 cmFuZG9tX3N0aXIodm9pZCkKIHsKKwogCUxPQ0soJnJzKTsKLQlhcmM0X3N0aXIoJnJzKTsKKwlh
 cmM0X3N0aXIoJnJzLCBnZXRwaWQoKSk7CiAJVU5MT0NLKCZycyk7CiB9CiAKIHZvaWQKIGFyYzRy
 YW5kb21fYWRkcmFuZG9tKHVfY2hhciAqZGF0LCBpbnQgZGF0bGVuKQogeworCiAJTE9DSygmcnMp
 OwotCWFyYzRfY2hlY2tfaW5pdCgmcnMpOworCWFyYzRfc3Rpcl9pZl9uZWVkZWQoJnJzLCBkYXRs
 ZW4pOwogCWFyYzRfYWRkcmFuZG9tKCZycywgZGF0LCBkYXRsZW4pOwogCVVOTE9DSygmcnMpOwog
 fQpAQCAtMjA2LDcgKzIxNCw3IEBAIGFyYzRyYW5kb20odm9pZCkKIAl1aW50MzJfdCB2OwogCiAJ
 TE9DSygmcnMpOwotCWFyYzRfY2hlY2tfaW5pdCgmcnMpOworCWFyYzRfc3Rpcl9pZl9uZWVkZWQo
 JnJzLCBzaXplb2YodikpOwogCXYgPSBhcmM0X2dldHdvcmQoJnJzKTsKIAlVTkxPQ0soJnJzKTsK
 IAlyZXR1cm4gdjsKQEAgLTIyMCw3ICsyMjgsNyBAQCBhcmM0cmFuZG9tX2J1Zih2b2lkICpidWYs
 IHNpemVfdCBsZW4pCiAJdWludDhfdCBpLCBqOwogCiAJTE9DSygmcnMpOwotCWFyYzRfY2hlY2tf
 aW5pdCgmcnMpOworCWFyYzRfc3Rpcl9pZl9uZWVkZWQoJnJzLCBsZW4pOwogCiAJLyogY2FjaGUg
 aSBhbmQgaiAtIGNvbXBpbGVyIGNhbid0IGtub3cgJ2J1ZicgZG9lc24ndCBhbGlhcyB0aGVtICov
 CiAJaSA9IHJzLmk7CkBAIC0yNjMsNyArMjcxLDcgQEAgYXJjNHJhbmRvbV91bmlmb3JtKHVpbnQz
 Ml90IHVwcGVyX2JvdW5kKQogCW1pbiA9ICgweEZGRkZGRkZGVSAtIHVwcGVyX2JvdW5kICsgMSkg
 JSB1cHBlcl9ib3VuZDsKIAogCUxPQ0soJnJzKTsKLQlhcmM0X2NoZWNrX2luaXQoJnJzKTsKKwlh
 cmM0X3N0aXJfaWZfbmVlZGVkKCZycywgc2l6ZW9mKHIpKTsKIAogCS8qCiAJICogVGhpcyBjb3Vs
 ZCB0aGVvcmV0aWNhbGx5IGxvb3AgZm9yZXZlciBidXQgZWFjaCByZXRyeSBoYXMK
 --=_78a787e1cccc4ca0768aab6f423d85a8--