re: kern/48579

[Quentin Garnier <cube%cubidou.net@localhost>]

The following reply was made to PR kern/48579; it has been noted by GNATS.

From: Quentin Garnier <cube%cubidou.net@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: re: kern/48579
Date: Thu, 1 May 2014 17:14:52 +0000

 config(5) allows for dependencies between elements precisely so that the
 problem experienced by the submitter would not happen.  If something is
 wrong with the user's kernel configuration file, then config(1) should
 emit an error.  It seems to me like a perfectly fine expectation.
 
 Concerning the fact that enabling bicc@isa but removing le@bicc does
 not make sense, well, I would say that it is not up to config(1) to
 decide of that.  'rm -Rf /' makes little sense either.
 
 There is a lot of abuse, especially in the indirect configuration busses
 of the parent/child dependency.  This one is but one example.
 
 The following patch will fix that issue by making bicc itself dependent
 on the bus-independent le code.  It also removes the then redundant
 dependency of le@bicc.
 
 Index: dev/isa/files.isa
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/isa/files.isa,v
 retrieving revision 1.163
 diff -u -u -r1.163 files.isa
 --- dev/isa/files.isa   10 Jun 2013 07:14:02 -0000      1.163
 +++ dev/isa/files.isa   1 May 2014 16:20:48 -0000
 @@ -235,9 +235,9 @@
  device nele {}
  attach nele at isa
  attach le at nele with le_nele: le24, isadma
 -device bicc {}
 +device bicc {}: le24
  attach bicc at isa
 -attach le at bicc with le_bicc: le24, isadma
 +attach le at bicc with le_bicc: isadma
  file   dev/isa/if_le_isa.c             nele | bicc
  attach depca at isa with depca_isa
  file   dev/isa/depca_isa.c             depca
 
 The firewire issue is a little bit more complicated to entangle because
 of all the inter-dependencies of all the firewire code and ultimately a
 dependency on ieee1394if_cd, which only exists if ieee1394@fwbus is
 selected.  Making firewire.c, fwdma.c and fwcrom.c depend on fwbus helps
 a lot but it still needs fwmem_{read,write}_quad from fwmem which in
 turn depends on ieee1394if_cd.
 
 -- 
 Quentin Garnier - cube%cubidou.net@localhost
 "See the look on my face from staying too long in one place
 [...] every time the morning breaks I know I'm closer to falling"
 KT Tunstall, Saving My Face, Drastic Fantastic, 2007.