Re: toolchain/48627: CTFCONVERT is set depending on properties of the build host

[Ryota Ozaki <ozaki-r%NetBSD.org@localhost>]

On Thu, Mar 6, 2014 at 12:33 AM, Christos Zoulas 
<christos%zoulas.com@localhost> wrote:
> On Mar 5, 10:33am, ozaki-r%NetBSD.org@localhost (Ryota Ozaki) wrote:
> -- Subject: Re: toolchain/48627: CTFCONVERT is set depending on properties of
>
> | Could I commit the patch? Christos?
> |
> | The fix also helps my work :)
>
> The bsd.own.mk fix is probably fine (but does not really make a difference),

This fix makes sense when we build tools with MKDTRACE but build kernel w/o
MKDTRACE (i.e., build.sh -V MKDTRACE=yes tools; build.sh kernel=GENERIC);
without the fix, nbctfconvert unexpectedly runs w/o MKDTRACE.

BTW, nbctfconvert to the kernel unfortunately fails for now, so running it w/o
MKDTRACE annoyed me.

> but the sys.mk cannot possibly work because sys.mk is the first file to be
> loaded by make:
>
> $ cd /usr/src/usr.bin/make
> $ ktrace make
> $ kdump | grep NAMI
>   3968      1 ktrace   NAMI  "./make"
>   3968      1 ktrace   NAMI  "/usr/bin/make"
>   3968      1 ktrace   NAMI  "/usr/libexec/ld.elf_so"
>   3968      1 make     NAMI  "/etc/ld.so.conf"
>   3968      1 make     NAMI  "/usr/lib/libutil.so.7"
>   3968      1 make     NAMI  "/usr/lib/libgcc_s.so.1"
>   3968      1 make     NAMI  "/usr/lib/libc.so.12"
>   3968      1 make     NAMI  "/etc/malloc.conf"
>   3968      1 make     NAMI  "/usr/src/usr.bin/make"
>   3968      1 make     NAMI  "/usr/src/usr.bin/make"
>   3968      1 make     NAMI  "/usr/src/usr.bin/make"
>   3968      1 make     NAMI  "/usr/src/usr.bin/make"
>   3968      1 make     NAMI  "/usr/src/usr.bin/make"
>   3968      1 make     NAMI  "."
>   3968      1 make     NAMI  "/usr/src/usr.bin/make/obj.amd64"
>   3968      1 make     NAMI  "/usr/src/usr.bin/make/obj.amd64"
>   3968      1 make     NAMI  "."
>   3968      1 make     NAMI  "/usr/share/mk"
>   3968      1 make     NAMI  "/usr/share/mk/sys.mk"
>
> So, I don't think that the patch is correct. How have you tested that it 
> works?

I tested only for my case and I thought the fix could be applied to the other.
I'm sorry, I jumped to conclusions.

  ozaki-r

>
> christos