Re: bin/48624 (atf integration seriously broken)

[jmmv%NetBSD.org@localhost]

Synopsis: atf integration seriously broken

State-Changed-From-To: open->analyzed
State-Changed-By: jmmv%NetBSD.org@localhost
State-Changed-When: Sun, 02 Mar 2014 20:35:02 +0000
State-Changed-Why:
This is with an unclean object tree, right?

After the upgrade, I changed the test-programs Makefile to auto-generate
an Atffile, which resulted in various helper programs being registered as
tests.  This is incorrect.

I later undid this change to rely on a manually-crafted Atffile.
Unfortunately, I suppose your object tree still has an Atffile and this is
being preferred over the one in the source tree.

Cleaning your object tree should fix this.

However, we should also fix bsd.test.mk to prevent this altogether.
The solution I applied to FreeBSD was to name the auto-generated files as
Atffile.auto or similar and only perform the rename during install.  This
way, the two can never be confused.  How does that sound?