bin/48582: Multiple ATF tests now fail with "Invariant check failed"

[gson%gson.org@localhost (Andreas Gustafsson)]

>Number:         48582
>Category:       bin
>Synopsis:       Multiple ATF tests fail with "Invariant check failed"
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sun Feb 09 15:45:00 +0000 2014
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current, source date 2014.02.09.01.46.10
>Organization:

>Environment:
System: NetBSD
Architecture: i386
Machine: i386
>Description:

Since the recent import of atf 0.19, a number of tests that previously
passed are failing.  Here is the standard error from one of them:

   t_paths: Invariant check failed at 
/tmp/bracket/build/2014.02.08.19.45.51-i386/src/external/bsd/atf/dist/atf-c/config.c:146:
 value != NULL
   t_paths: 
   t_paths: This is probably a bug in this application or one of the libraries 
it uses.  If you believe this problem is caused by, or is related to Automated 
Testing Framework 0.17, please report it to atf-devel%NetBSD.org@localhost and 
provide as many detatils as possible describing how you got to this condition.
   Test program crashed; attempting to get stack trace
   [New process 1]
   Core was generated by `t_paths'.
   Program terminated with signal 6, Aborted.
   #0  0xbbb6b457 in _lwp_kill () from /usr/lib/libc.so.12
   #0  0xbbb6b457 in _lwp_kill () from /usr/lib/libc.so.12
   #1  0xbbb6b3f3 in raise () from /usr/lib/libc.so.12
   #2  0xbbb6aff1 in abort () from /usr/lib/libc.so.12
   #3  0xbbbde1b6 in ?? () from /usr/lib/libatf-c.so.0
   #4  0xbbbde1ec in atf_sanity_inv () from /usr/lib/libatf-c.so.0
   #5  0xbbbd7d8b in atf_config_get () from /usr/lib/libatf-c.so.0
   #6  0x08048d10 in atfu_paths_body ()
   #7  0xbbbd929e in atf_tc_run () from /usr/lib/libatf-c.so.0
   #8  0xbbbd5d41 in atf_tp_run () from /usr/lib/libatf-c.so.0
   #9  0xbbbd558e in atf_tp_main () from /usr/lib/libatf-c.so.0
   #10 0x0804913d in main ()
   Stack trace complete

Examining a core dump with gdb shows atf_config_get() being called
with an argument of "atf_arch".

>How-To-Repeat:

Inspect the output from the TNF test server, for example

  
http://releng.netbsd.org/b5reports/i386/build/2014.02.08.19.45.51/test.html#failed-tcs-summary

and look for failed tests with a Reason of "Test program received
signal 6 (core dumped)".

>Fix: