Re: misc/48555: rc.conf handling of program=yes/no

[Valery Ushakov <uwe%stderr.spb.ru@localhost>]

The following reply was made to PR misc/48555; it has been noted by GNATS.

From: Valery Ushakov <uwe%stderr.spb.ru@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: misc/48555: rc.conf handling of program=yes/no
Date: Tue, 28 Jan 2014 02:20:09 +0400

 On Mon, Jan 27, 2014 at 15:50:01 +0000, Alan Barrett wrote:
 
 >  Is this dirmngr from pkgsrc/security/dirmngr?  Try changing 
 >  line 56 of /etc/rc.d/dirmngr from
 >  
 >      eval `${dirmngr_command} ${rc_flags}`
 >  
 >  to
 >  
 >      eval "${dirmngr_command} ${rc_flags}"
 >  
 >  (double quotes instead of backticks).  I have not tested this, but 
 >  it's possible that it will help.
 
 Backticks are definitely wrong here.  Eval is unnecessary.  And
 required_* stuff is handled by run_rc_command already.  check_process
 should be used too instead of doing it manually.
 
 So I'd say, recategorize this against pkgsrc to fix the rc.d file.
 
 -uwe