Re: kern/48308: User can crash machine using a USB webcam

[Nick Hudson <skrll%netbsd.org@localhost>]

The following reply was made to PR kern/48308; it has been noted by GNATS.

From: Nick Hudson <skrll%netbsd.org@localhost>
To: Dave Tyson <dtyson%anduin.org.uk@localhost>
Cc: gnats-bugs%NetBSD.org@localhost, Mihai Chelaru 
<mihai.chelaru%ngnetworks.ro@localhost>, 
 kern-bug-people%netbsd.org@localhost, gnats-admin%netbsd.org@localhost, 
 netbsd-bugs%netbsd.org@localhost
Subject: Re: kern/48308: User can crash machine using a USB webcam
Date: Wed, 06 Nov 2013 08:30:28 +0000

 On 11/05/13 16:38, Dave Tyson wrote:
 > On 11/04/13 19:40, Mihai Chelaru wrote:
 >> The following reply was made to PR kern/48308; it has been noted by GNATS.
 >>
 >> [more snipping]
 >>   Probably it works in 6.1 because release kernels are not compiled with
 >>   options DIAGNOSTIC, so they don't trigger that assert. I use the
 >>   attached patch for some time without any problems. It should fix your
 >>   issue too.
 >>   
 >>   --
 >>   Mihai
 >>   
 > <patch snipped to save bandwidth>
 >
 >
 >
 > Hi Mihai,
 > thanks for looking at this PR. I realised after I had posted it that
 > having options DIAGNOSTIC in GENERIC triggered the assert and removing
 > this enabled the webcam to work OK. However it needs to be fixed before
 > NetBSD-7 is branched:-)
 >
 > I have applied your patch (it went on cleanly against the latest
 > usb_mem.c 1.63), however the kernel still panics under GENERIC in a
 > different place:
 >
 > panic: kernel diagnostic assertion "(!cpu_intr_p() && !cpu_softintr_p())
 > || (pc->pc_pool.pr_ipl != IPL_NONE || cold || panicstr != NULL)" failed: file
 > "/usr/src/sys/kern/subr_pool.c", line 2209 pool 'pvpl' is IPL_NONE, but 
 > called from interrupt context
 
 USB memory management needs a revamp
 
 Nick