Re: install/48303: Linux cross build fails on ppc

[Alan Barrett <apb%cequrux.com@localhost>]

The following reply was made to PR toolchain/48303; it has been noted by GNATS.

From: Alan Barrett <apb%cequrux.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: install/48303: Linux cross build fails on ppc
Date: Mon, 28 Oct 2013 14:57:38 +0200

 On Mon, 28 Oct 2013, Justin Cormack wrote:
 >I looked at where this was being redefined and it is in compat_defs.h
 >and the following patch fixes this issue, which makes it somewhat
 >simpler than I thought to fix. The only question is whether undefining
 >__unused is necessary on some other platform, in which case the
 >#define __unused could be wrapped eg in #ifndef __linux__ which should
 >be safe.
 
 Is the Linux use of "__unused" as a struct member name something new?
 
 Did you test a complete build with your patch?  The reason for the
 "#define __unused", which has been in compat_defs.h since 2006-10-12, is
 to deal with code that uses __unused in the NetBSD way, like
 
        sometype varname __unused;
 
 and if __unused is not defined then such code would cause a syntax
 error.  There seems to be such code in src/usr.sbin/makefs, which would
 be built from src/tools/makefs.  There might also be more uses of
 __unused in the tools build.
 
 --apb (Alan Barrett)