Re: misc/48338: netbsd-iscsi-20080207/src/util.c:1165: possible bad if test ?

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR misc/48338; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: misc/48338: netbsd-iscsi-20080207/src/util.c:1165: possible bad if 
test ?
Date: Thu, 24 Oct 2013 21:12:32 +0200

 --uAKRQypu60I7Lcqm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: inline
 
 I've commited this patch.
 
 Martin
 
 
 --uAKRQypu60I7Lcqm
 Content-Type: text/plain; charset=us-ascii
 Content-Disposition: attachment; filename=patch
 
 Index: util.c
 ===================================================================
 RCS file: /cvsroot/src/external/bsd/iscsi/dist/src/lib/util.c,v
 retrieving revision 1.3
 diff -u -r1.3 util.c
 --- util.c     15 Mar 2012 04:06:55 -0000      1.3
 +++ util.c     24 Oct 2013 19:11:49 -0000
 @@ -1273,7 +1273,7 @@
        uint32_t    n2;
        uint32_t    len = 0;
  
 -      if ((text[0] == '0') && (text[1] != 'x' || text[1] != 'X')) {
 +      if ((text[0] == '0') && (text[1] == 'x' || text[1] == 'X')) {
                /* skip prefix */
                text += 2;
                textLength -= 2;
 
 --uAKRQypu60I7Lcqm--