Re: kern/48135 Bad locking for umount

[Michael van Elst <mlelstv%serpens.de@localhost>]

The following reply was made to PR kern/48135; it has been noted by GNATS.

From: Michael van Elst <mlelstv%serpens.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/48135 Bad locking for umount
Date: Mon, 14 Oct 2013 20:05:23 +0200

 On Mon, Oct 14, 2013 at 10:40:00AM +0000, J. Hannken-Illjes wrote:
 >  Michael,
 >  
 >  are you sure both vfs_destroy() on cpu 1 and VFS_SYNC() on cpu 0
 >  refer to the same mount?
 
 No, could be something different.
 
 >  VFS-SYNC() calling wapbl_XXX looks strange.
 
 int
 ffs_sync(struct mount *mp, int waitfor, kauth_cred_t cred)
 {
 ...
 
 #ifdef WAPBL
         if (mp->mnt_wapbl) {
                 error = wapbl_flush(mp->mnt_wapbl, 0);
                 if (error)
                         allerror = error;
         }
 #endif
 
         fstrans_done(mp);
         vnfree(mvp);
         return (allerror);
 }
 
 
 Greetings,
 -- 
                                 Michael van Elst
 Internet: mlelstv%serpens.de@localhost
                                 "A potential Snark may lurk in every tree."