Re: kern/46545: pad(4):Support for fullduplex playback/recording polling and nonblocking mode

[Nat Sloss <nathanialsloss%yahoo.com.au@localhost>]

The following reply was made to PR kern/46545; it has been noted by GNATS.

From: Nat Sloss <nathanialsloss%yahoo.com.au@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: plunky%ogmig.net@localhost
Subject: Re: kern/46545: pad(4):Support for fullduplex playback/recording 
polling and nonblocking mode
Date: Sat, 7 Sep 2013 21:32:12 +1000

 Hi,
 
 Here is a patch to the patched version of pad (Thanks to mrg for identifying 
 the problem):
 
 --- pad.c.patched      2013-09-07 21:25:35.000000000 +1000
 +++ pad.c      2013-09-07 20:32:57.000000000 +1000
 @@ -459,7 +459,9 @@
  
                if (intr) {
                        mutex_enter(&sc->sc_intr_lock);
 +                      kpreempt_disable();
                        (*intr)(intrarg);
 +                      kpreempt_enable();
                        mutex_exit(&sc->sc_intr_lock);
                        intr = sc->sc_out_intr;
                        intrarg = sc->sc_out_intrarg;
 @@ -520,7 +522,9 @@
  
                if (intr) {
                        mutex_enter(&sc->sc_intr_lock);
 +                      kpreempt_disable();
                        (*intr)(intrarg);
 +                      kpreempt_enable();
                        mutex_exit(&sc->sc_intr_lock);
                        intr = sc->sc_in_intr;
                        intrarg = sc->sc_in_intrarg;
 
 
 And I found out why I received an IO error whilst using audiorecord with pad 
 the file that I inputted to pad was small and by the time it was starting to 
 record the pad device is closed.  Hopfully this is not a problem with my 
 modified bthset.
 
 Regards,
 
 Nat.