Re: PR/47884 CVS commit: xsrc/external/mit/xf86-video-openchrome/dist/src

[B Harder <brad.harder%gmail.com@localhost>]

The following reply was made to PR xsrc/47884; it has been noted by GNATS.

From: B Harder <brad.harder%gmail.com@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: PR/47884 CVS commit: 
xsrc/external/mit/xf86-video-openchrome/dist/src
Date: Mon, 3 Jun 2013 16:31:37 -0700

 Excellent. The fix was so fast, I hadn't even finished swallowing the
 mouthful of Cheerios from the time I submitted the report.
 
 I ran into the same issue w/ another file, and following your lead,
 humbly propose the following additional patch to xsrc:
 
 Index: external/mit/xf86-video-openchrome/dist/src/via_lvds.c
 ===================================================================
 RCS file: 
/cvsroot/xsrc/external/mit/xf86-video-openchrome/dist/src/via_lvds.c,v
 retrieving revision 1.1.1.2
 diff -r1.1.1.2 via_lvds.c
 1473c1473
 <     char aux[strlen(name) + 1];
 ---
 >     char *aux;
 1475a1476,1479
 >     aux=malloc(strlen(name)+1);
 >     if(aux == NULL)
 >       return;
 >
 1491a1496
 >    free(aux);
 
 On 6/3/13, Christos Zoulas <christos%netbsd.org@localhost> wrote:
 > The following reply was made to PR xsrc/47884; it has been noted by GNATS.
 >
 > From: "Christos Zoulas" <christos%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc:
 > Subject: PR/47884 CVS commit:
 > xsrc/external/mit/xf86-video-openchrome/dist/src
 > Date: Mon, 3 Jun 2013 18:44:40 -0400
 >
 >  Module Name:        xsrc
 >  Committed By:       christos
 >  Date:               Mon Jun  3 22:44:40 UTC 2013
 >
 >  Modified Files:
 >      xsrc/external/mit/xf86-video-openchrome/dist/src: via_display.c
 >
 >  Log Message:
 >  PR/47884: Brad Harder: Avoid variable stack allocation, use malloc for
 > SSP.
 >
 >
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.1.1.2 -r1.2 \
 >      xsrc/external/mit/xf86-video-openchrome/dist/src/via_display.c
 >
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >
 >
 
 
 -- 
 Brad Harder
 Method Logic Digital Consulting
 http://www.methodlogic.net/
 http://twitter.com/bcharder