Re: kern/47646: Test dev/scsipi/t_cd:noisyeject broken

[Martin Husemann <martin%duskware.de@localhost>]

The following reply was made to PR kern/47646; it has been noted by GNATS.

From: Martin Husemann <martin%duskware.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: Manuel Bouyer <bouyer%antioche.eu.org@localhost>, Antti Kantee 
<pooka%NetBSD.org@localhost>
Subject: Re: kern/47646: Test dev/scsipi/t_cd:noisyeject broken
Date: Fri, 15 Mar 2013 11:32:16 +0100

 Actually there is no error involved, the value comes from here:
 
 182             case SCSI_READ_6_COMMAND: {
 183     #ifdef USE_TOSI_ISO
 184                     struct scsi_rw_6 *param = (void *)cmd;
 185     
 186                     printf("reading %d bytes from %d\n",
 187                         param->length * CDBLOCKSIZE,
 188                         _3btol(param->addr) * CDBLOCKSIZE);
 189                     rumpuser_pread(isofd, xs->data,
 190                          param->length * CDBLOCKSIZE,
 191                          _3btol(param->addr) * CDBLOCKSIZE,
 192                          &error);
 193     #endif
 194     
 195                     break;
 
 
 with this backtrace:
 
 #0  scsitest_request (chan=0x7f7ff6b26480, req=ADAPTER_REQ_RUN_XFER, 
     arg=0x7f7ff7be2f00) at /usr/src/sys/rump/dev/lib/libscsitest/scsitest.c:205
 #1  0x00007f7ff741fda5 in scsipi_run_queue (chan=0x7f7ff6b26480)
     at 
/usr/src/sys/rump/dev/lib/libscsipi/../../../../dev/scsipi/scsipi_base.c:1845
 #2  0x00007f7ff742010c in scsipi_execute_xs (xs=0x7f7ff7be2f00)
     at 
/usr/src/sys/rump/dev/lib/libscsipi/../../../../dev/scsipi/scsipi_base.c:1970
 #3  0x00007f7ff7420f3b in scsipi_command (periph=0x7f7ff6301f08, 
     cmd=0x7f7fffffcae0, cmdlen=10, data_addr=0x7f7ff630e808 "", datalen=1024, 
     retries=4, timeout=30000, bp=0x0, flags=4096)
     at 
/usr/src/sys/rump/dev/lib/libscsipi/../../../../dev/scsipi/scsipiconf.c:101
 #4  0x00007f7ff741854f in mmc_getdiscinfo (periph=0x7f7ff6301f08, 
     mmc_discinfo=0x7f7fffffd080)
     at /usr/src/sys/rump/dev/lib/libscsipi/../../../../dev/scsipi/cd.c:3038
 
 
 and the xs is:
 
 $8 = {channel_q = {tqe_next = 0x0, tqe_prev = 0x7f7ff6b26548}, device_q = {
     tqe_next = 0x0, tqe_prev = 0x7f7ff6301f90}, xs_callout = {_c_store = {0x0, 
       0x0, 0x0, 0x0, 0x7f7ff66c68a0, 0x100000000, 0x11deeba1, 0x0, 0x0, 0x0}}, 
   xs_control = 4096, xs_status = 0, xs_periph = 0x7f7ff6301f08, 
   xs_retries = 4, xs_requeuecnt = 0, timeout = 30000, cmd = 0x7f7ff7be2fec, 
   cmdlen = 10, data = 0x7f7ff630e808 "", datalen = 1024, resid = 1024, 
   error = XS_NOERROR, bp = 0x0, sense = {scsi_sense = {
 ...
 
 
 So the (simulated) device, when told to read 1024 bytes, reads 0 bytes
 and signals no error - is that OK?
 
 Martin