Re: kern/47302: isp: bad handle on teardown

[Steven Chamberlain <steven%pyro.eu.org@localhost>]

The following reply was made to PR kern/47302; it has been noted by GNATS.

From: Steven Chamberlain <steven%pyro.eu.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/47302: isp: bad handle on teardown
Date: Mon, 25 Feb 2013 00:37:35 +0000

 Hi,
 
 I was able to re-test this with the new sequence numbers turned off,
 leaving the high 16 bits all zero.  With the same card as before:
 
 006:01:0: QLogic ISP2100 (SCSI mass storage, revision 0x04)
 
 This fixes the issue for me, and my attached FC-AL drives are detected
 and working fine so far.  Although I can't explain exactly what the
 problem was, I just speculated that my card maybe only supports 16-bit
 handles.  Or it could be that the 32-bit handles are okay but the driver
 was not verfying them properly.
 
 diff -u -r1.7 isp_library.c
 --- src/sys/dev/ic/isp_library.c        28 Feb 2011 17:17:55 -0000      1.7
 +++ src/sys/dev/ic/isp_library.c        25 Feb 2013 00:28:48 -0000
 @@ -258,7 +258,8 @@
         hdp->cmd = xs;
         hdp->handle = (hdp - isp->isp_xflist);
         hdp->handle |= (ISP_HANDLE_INITIATOR << ISP_HANDLE_USAGE_SHIFT);
 -       hdp->handle |= (isp->isp_seqno++ << ISP_HANDLE_SEQ_SHIFT);
 +       if (!IS_2100(isp))
 +               hdp->handle |= (isp->isp_seqno++ << ISP_HANDLE_SEQ_SHIFT);
         *handlep = hdp->handle;
         return (0);
  }
 
 Thanks,
 Regards,
 -- 
 Steven Chamberlain
 steven%pyro.eu.org@localhost