Re: bin/47524: make(1) loops in Job_CatchOutput()

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR bin/47524; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Andreas Gustafsson <gson%gson.org@localhost>, dsl%NetBSD.org@localhost
Cc: gnats-bugs%NetBSD.org@localhost
Subject: Re: bin/47524: make(1) loops in Job_CatchOutput()
Date: Wed, 6 Feb 2013 11:02:21 -0500

 On Feb 6, 11:40am, gson%gson.org@localhost (Andreas Gustafsson) wrote:
 -- Subject: Re: bin/47524: make(1) loops in Job_CatchOutput()
 
 | If the purpose of 1.165 was specifically to suppress a compiler
 | warning on Linux, surely there must be some way of doing that without
 | changing the generated object code.  On the other hand, if what we
 | want is to change the behavior of the code to actually check the
 | return value instead of just suppressing a warning, then I think the
 | complexity of my "ridiculous number of tests" is pretty much
 | unavoidable.
 
 Irrespective for the reason of the change the current code is more complicated
 than it needs to be and incorrect. It just happens to work.
 
 christos