[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
Re: bin/47524: make(1) loops in Job_CatchOutput()
The following reply was made to PR bin/47524; it has been noted by GNATS.
From: Andreas Gustafsson <gson%gson.org@localhost>
To: David Laight <david%l8s.co.uk@localhost>
Andreas Gustafsson <gson%gson.org@localhost>,
Subject: Re: bin/47524: make(1) loops in Job_CatchOutput()
Date: Tue, 5 Feb 2013 09:56:49 +0200
David Laight wrote:
> I moved the Job_CatchChildren() from being called unconditionally
> everytime around the loop, to be (usually) only called when a
> token was read from the pipe.
> But I didn't want to break the code if it was actually relying on the
> poll timeout (5 seconds) to collect children.
But in the timeout case, poll() will return 0, not < 0, therefore
Job_CatchChildren() will in fact *not* be called when there is a
timeout. It will, however, be called if the poll() system call
fails. Should the "nready < 0" have been "nready == 0"?
Andreas Gustafsson, gson%gson.org@localhost
Main Index |
Thread Index |