NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/47245: Add AX88772B support to axe(4), e.g. for DLINK DUB-E100 C1



The following reply was made to PR kern/47245; it has been noted by GNATS.

From: "David H. Gutteridge" <dhgutteridge%sympatico.ca@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: christos%netbsd.org@localhost
Subject: Re: kern/47245: Add AX88772B support to axe(4), e.g. for DLINK 
DUB-E100 C1
Date: Wed, 5 Dec 2012 23:18:32 -0500

 This PR also relates to PR 46076.  I did notice there's a remaining
 difference between the fix committed in OpenBSD revision 1.109 and
 NetBSD revision 1.58.  While I'm hardly an expert at driver coding,
 the OpenBSD version seems correct (I don't follow why a byte-swapped
 value would have a non-byte-swapped bitmask applied to it):
 
 --- if_axe.c.orig      2012-12-05 22:02:51.000000000 -0500
 +++ if_axe.c   2012-12-05 22:04:36.000000000 -0500
 @@ -929,7 +929,7 @@
                                goto done;
                        }
 
 -                      rxlen = le16toh(hdr.len & AXE_RH1M_RXLEN_MASK);
 +                      rxlen = le16toh(hdr.len) & AXE_RH1M_RXLEN_MASK;
                        if (total_len < rxlen) {
                                pktlen = total_len;
                                total_len = 0;
 
 Could all these fixes please be pulled up to the netbsd-6 branch?
 
 Regards,
 
 Dave
 


Home | Main Index | Thread Index | Old Index