NetBSD-Bugs archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]
PR/47270 CVS commit: src/sys/external/bsd/ipf/netinet
The following reply was made to PR bin/47270; it has been noted by GNATS.
From: "Christos Zoulas" <christos%netbsd.org@localhost>
To: gnats-bugs%gnats.NetBSD.org@localhost
Cc:
Subject: PR/47270 CVS commit: src/sys/external/bsd/ipf/netinet
Date: Mon, 3 Dec 2012 13:30:26 -0500
Module Name: src
Committed By: christos
Date: Mon Dec 3 18:30:25 UTC 2012
Modified Files:
src/sys/external/bsd/ipf/netinet: ip_dstlist.c
Log Message:
PR/47270: Paul Goyette: ipftest -N aborts
1. check for NULL before de-refencing; in particular sel is assigned to NULL,
in the default case, and then couple of lines down we do sel->
2. gcc appears to optimize u_32_t hash[4], to u_32_t hash, since we only
use hash[0], disregarding the fact that we pass it to MD5Final() leading
to stack corruption. Use an explicit union, so that the compiler stops
butting its head where it shouldn't.
XXX: pullup to 6
To generate a diff of this commit:
cvs rdiff -u -r1.4 -r1.5 src/sys/external/bsd/ipf/netinet/ip_dstlist.c
Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.
Home |
Main Index |
Thread Index |
Old Index