NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: bin/47101 (ipmon(8) alignment problem on 32-bit sparc)



The following reply was made to PR bin/47101; it has been noted by GNATS.

From: nakayama%NetBSD.org@localhost
To: david%l8s.co.uk@localhost
Cc: gnats-bugs%NetBSD.org@localhost, darrenr%NetBSD.org@localhost, 
gnats-admin%netbsd.org@localhost,
        netbsd-bugs%netbsd.org@localhost
Subject: Re: bin/47101 (ipmon(8) alignment problem on 32-bit sparc)
Date: Fri, 26 Oct 2012 17:31:52 +0900 (JST)

 > On Thu, Oct 25, 2012 at 10:15:05PM +0000, Takeshi Nakayama wrote:
 >>  We need something as below.
 > 
 > Does that even compile ?
 
 Yes.
 
 >>  +print_natlog(config_t *conf, const void *buf, const iplog_t *ipl)
 >>  { ... }
 > 
 >>  +print_statelog(config_t *conf, const void *buf, const iplog_t *ipl)
 >>  { ...
 >>  +                          print_ipflog(conf, buf, &ipl);
 > ...
 >>  +                          print_natlog(conf, buf, &ipl);
 > ...
 >>  +                          print_statelog(conf, buf, &ipl);
 >> ... }
 >>   
 >>  +print_ipflog(config_t *conf, const  void *buf, const iplog_t *ipl)
 > { ... }
 > 
 > I also can't see where you are doing the 'realignment copy'.
 
 'iplog_t ipl' in print_log().
 
     http://nxr.netbsd.org/xref/src/external/bsd/ipf/dist/tools/ipmon.c#1003
 
 Then it is passed to print_ipflog(), print_natlog() and print_statelog().
 
 -- Takeshi Nakayama
 


Home | Main Index | Thread Index | Old Index