kern/46980: genfs rename code failed to call vrele() on special error

[Wolfgang.Stukenbrock%nagler-company.com@localhost]

>Number:         46980
>Category:       kern
>Synopsis:       genfs rename code failed to call vrele() on special error
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Sep 18 13:50:00 +0000 2012
>Originator:     Dr. Wolfgang Stukenbrock
>Release:        NetBSD current
>Organization:
Dr. Nagler & Company GmbH
>Environment:
        
        
System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #0: Tue Aug 17 17:28:09 CEST 
2010 wgstuken@test-s0:/usr/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
        in genfs_rename_enter_common() if the destination is '.' the allocated
        tvp vnode is not released again.
        EISDIR is returned, but the ' goto fail2' will only release the
        previously allocated fvp vnode.
        This problem only comes up if someone is tryining to rename
        something to '...xx/.', so this is a rare case in real world ...
>How-To-Repeat:
        found by a look into the sources
>Fix:
        add another label in the chain of lables and call vrele(tvp) ...

>Unformatted: