NetBSD-Bugs archive

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index][Old Index]

Re: kern/46961: Please support BCM57762 Ethernet arapter(Apple'sThunderbolt Ethernet Adapter)



The following reply was made to PR kern/46961; it has been noted by GNATS.

From: Izumi Tsutsui <tsutsui%ceres.dti.ne.jp@localhost>
To: david%l8s.co.uk@localhost
Cc: gnats-bugs%NetBSD.org@localhost, tsutsui%ceres.dti.ne.jp@localhost
Subject: Re: kern/46961: Please support BCM57762 Ethernet 
arapter(Apple'sThunderbolt
         Ethernet Adapter)
Date: Mon, 17 Sep 2012 16:38:57 +0900

 david@ wrote:
 
 >  There are all sorts of reasons why an rx buffer size of 1536 is a good idea.
 >  Mostly because it is a nice round number!
 
 I don't see any benefits by rounding the number in this case.
 
 >  It might even be that the register it gets written to has non-writeable
 >  low bits.
 
 Broadcom's programmer's guide mentions no such "non-writeable low bits".
 
 >  Allowing 'slightly overlong' packets is useful for certain protocols,
 >  I'm sure I remember something else, as well as VLAN, extending the
 >  maximum length.
 
 Then shouldn't it be defined in MI sys/net headers?
 Why don't we only have ETHERCAP_VLAN_MTU and ETHERCAP_JUMBO_MTU
 in the capability flag?
 
 Anyway "syncing with the original FreeBSD's driver" is a good reason
 for me because we no longer have particular maintainers of this driver.
 (and no reason to pull OpenBSD's ETHER_MAX_DIX_LEN macro)
 
 ---
 Izumi Tsutsui
 


Home | Main Index | Thread Index | Old Index