kern/46874: missing newline in printout for MFI controler if no subtype is present

[Wolfgang.Stukenbrock%nagler-company.com@localhost]

>Number:         46874
>Category:       kern
>Synopsis:       missing newline in printout for MFI controler if no subtype is 
>present
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    kern-bug-people
>State:          open
>Class:          change-request
>Submitter-Id:   net
>Arrival-Date:   Wed Aug 29 16:20:00 +0000 2012
>Originator:     Wolfgang Stukenbrock
>Release:        NetBSD current
>Organization:
Dr. Nagler & Company GmbH
>Environment:
        
        
System: NetBSD test-s0 4.0 NetBSD 4.0 (NSW-WS) #0: Tue Aug 17 17:28:09 CEST 
2010 wgstuken@test-s0:/usr/src/sys/arch/amd64/compile/NSW-WS amd64
Architecture: x86_64
Machine: amd64
>Description:
        On mfi-controler without sub-type a newline is missing in the boot 
messages prior
        the interrupt-at line.
>How-To-Repeat:
        Boot on a system with such a controler.
>Fix:
        The following patch will solve the problem.
        It will print out the name from pcidevs if possible or simply add the 
new line to the output.

diff -u -r1.3 mfi_pci.c
--- mfi_pci.c   2012/08/29 16:01:23     1.3
+++ mfi_pci.c   2012/08/29 16:11:03
@@ -207,6 +207,13 @@
                        aprint_normal(": vendor 0x%x product 0x%x\n",
                            PCI_VENDOR(subsysid), PCI_PRODUCT(subsysid));
                }
+       } else {
+               subtype = pci_findproduct(pa->pa_id);
+               if (subtype) {
+                       aprint_normal(": %s\n", subtype);
+               } else {
+                       aprint_normal("\n");
+               }
        }
 
        aprint_normal("%s: interrupting at %s\n", DEVNAME(sc), intrstr);

>Unformatted: