Re: misc/46757:

[Edgar Fuß <ef%math.uni-bonn.de@localhost>]

The following reply was made to PR misc/46757; it has been noted by GNATS.

From: Edgar =?iso-8859-1?B?RnXf?= <ef%math.uni-bonn.de@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: misc/46757:
Date: Tue, 31 Jul 2012 00:52:30 +0200

 On Mon, Jul 30, 2012 at 10:15:06PM +0000, Julian Djamil Fagir wrote:
 > though I was the one proposing this way, it doesn't work.
 Sorry, I was in a hurry and didn't test what I wrote.
 
 > I don't see this problem can be solved with the way checkyesno
 > currently works.
 I think it can. Quite simply (tested, this time) by reversing the order
 of the tests (I also corrected the placement of two 'echo ""' statements
 and the "Fetching..." message while there):
 
 --- daily.orig 2012-07-30 17:15:38.000000000 +0200
 +++ daily      2012-07-31 00:46:20.000000000 +0200
 @@ -237,8 +237,8 @@
        fsck -n -f ${run_fsck_flags} | grep -v '^\*\* Phase'
  fi
  
 -echo ""
  if checkyesno run_rdist && [ -f /etc/Distfile ]; then
 +      echo ""
        echo "Running rdist:"
        if [ -d /var/log/rdist ]; then
                logf="$(date +%Y.%b.%d)"
 @@ -249,14 +249,15 @@
  fi
  
  if pkg_info ${_compat_K_flag} -q -E '*'; then
 -      echo ""
 -      echo "Fetching package vulnerabilities database:"
 -      if checkyesno fetch_pkg_vulnerabilities; then
 +      if [ -z "$fetch_pkg_vulnerabilities" ]; then
 +              echo "fetch_pkg_vulnerabilities is not set in daily.conf(5)."
 +              echo "You should set it to YES to enable vulnerability checks"
 +              echo "or set it to NO to get rid of this warning."
 +      elif checkyesno fetch_pkg_vulnerabilities; then
 +              echo ""
 +              echo "Fetching package vulnerabilities database:"
                ( umask 022 && pkg_admin ${_compat_K_flag} \
                    fetch-pkg-vulnerabilities -u )
 -      else
 -              echo "fetch_pkg_vulnerabilities is set to NO in daily.conf(5)."
 -              echo "You should set it to YES to enable vulnerability checks."
        fi
  fi
  
 
 Sorry for the non-working first patch.