lib/46561: Remove self-assignment from getaddrinfo.c

[henning.petersen%t-online.de@localhost]

>Number:         46561
>Category:       lib
>Synopsis:       Remove self-assignment from getaddrinfo.c
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    lib-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Fri Jun 08 07:50:00 +0000 2012
>Originator:     Henning Petersen
>Release:        NetBSD-current
>Organization:
>Environment:
>Description:
Remove self-assignment from getaddrinfo.c
>How-To-Repeat:

>Fix:
diff -u -p -r1.100 getaddrinfo.c
--- lib/libc/net/getaddrinfo.c  20 Mar 2012 12:04:01 -0000      1.100
+++ lib/libc/net/getaddrinfo.c  7 Jun 2012 02:54:27 -0000
@@ -436,7 +436,7 @@ getaddrinfo(const char *hostname, const 
                }
                error = get_portmatch(pai, servname, &svd);
                if (error)
-                       ERR(error);
+                       goto bad;
 
                *pai = ai0;
        }