misc/46521: syntax error in an instance of test in /etc/weekly script 1.26

[jbernard%nool.mines.edu@localhost]

>Number:         46521
>Category:       misc
>Synopsis:       In /etc/weekly 1.26: ... if [ -x /usr/libexec/makewhatis ... 
>-o -o ...
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    misc-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Sat Jun 02 15:45:00 +0000 2012
>Originator:     Jim Bernard
>Release:        NetBSD 6.99.7
>Organization:
self
>Environment:
System: NetBSD 6.99.7 #0: Sat May 26 18:51:11 MDT 2012 i386
Architecture: i386
Machine: i386
>Description:
        The rebuild_whatisdb section contains an invocation of test with
        a folded line (lines 84 and 85), within which "-o" appears twice
        consecutively, once at the end of the first line, and once at the
        beginning of the second.  The offending construct is

          if [ -x /usr/libexec/makewhatis -a \( -f /etc/man.conf -o \
              -o -d /usr/share/man \) ]; then

>How-To-Repeat:
        Set rebuild_whatisdb=YES in /etc/weekly.conf and notice the message

          [: closing paren expected
          Not rebuilding whatis databases

        in the /etc/weekly report.
>Fix:
        Remove the redundancy.  E.g., change to:

          if [ -x /usr/libexec/makewhatis \
                -a \( -f /etc/man.conf -o -d /usr/share/man \) ]; then