Re: kern/46391: ums.c doesn't support digitizers or touchscreens

[Nat Sloss <nathanialsloss%yahoo.com.au@localhost>]

The following reply was made to PR kern/46391; it has been noted by GNATS.

From: Nat Sloss <nathanialsloss%yahoo.com.au@localhost>
To: gnats-bugs%netbsd.org@localhost
Cc: 
Subject: Re: kern/46391: ums.c doesn't support digitizers or touchscreens
Date: Tue, 1 May 2012 03:13:52 +1000

 Hi.
 
 
 Thanks Christos for the fast response.  I tested your patch and initially it 
 reported no buttons and it took me a while to find the problem but I found 
 it.
 
 --- ums.c.orig  2012-05-01 00:58:44.000000000 +1000
 +++ ums.c       2012-05-01 02:55:28.000000000 +1000
 @@ -323,11 +323,11 @@
         if (isdigitizer) {
                 for (size_t j = 0; j < __arraycount(digbut); j++) {
                         if (hid_locate(desc, size, HID_USAGE2(HUP_DIGITIZERS,
 -                           digbut[i].feature), uha->reportid, hid_input,
 +                           digbut[j].feature), uha->reportid, hid_input,
                             &sc->sc_loc_btn[i - 1], 0)) {
                                 if (i <= MAX_BUTTONS) {
                                         i++;
 -                                       sc->flags |= digbut[i].flag;
 +                                       sc->flags |= digbut[j].flag;
                                 } else
                                         aprint_error_dev(self,
                                             "ran out of buttons\n");
 
 Now all buttons are reported and it works perfectly.
 
 So thanks again.
 
 Regards,
 
 Nat.