Re: PR/44847 CVS commit: src/sys/sys

[christos%zoulas.com@localhost (Christos Zoulas)]

The following reply was made to PR standards/44847; it has been noted by GNATS.

From: christos%zoulas.com@localhost (Christos Zoulas)
To: Martin Husemann <martin%homeworld.netbsd.org@localhost>, 
gnats-bugs%NetBSD.org@localhost
Cc: jruohonen%iki.fi@localhost
Subject: Re: PR/44847 CVS commit: src/sys/sys
Date: Sun, 18 Mar 2012 10:25:02 -0400

 On Mar 18, 11:57am, martin%homeworld.netbsd.org@localhost (Martin Husemann) 
wrote:
 -- Subject: Re: PR/44847 CVS commit: src/sys/sys
 
 | On Sat, Mar 17, 2012 at 09:35:02PM +0000, Christos Zoulas wrote:
 | >  Log Message:
 | >  PR/44847: Jukka Ruohonen: blksize_t should be signed.
 | >  http://pubs.opengroup.org/onlinepubs/000095399/basedefs/sys/types.h.html
 | 
 | I object to this change, that part of the standard is obviously bogus
 | and should not be blindly followed.
 
 You realize that the internal kernel blocksize bookkeeping was already
 signed (va_blocksize)?
 
 | What use would a negative blocksize have?
 
 Don't know, but if you grep all 360+ usages of st_blksize in userland,
 they all assumed signed (except 1, in bin/cat).
 
 christos