Re: install/35538: sysinst duplicates hostname on upgrade

[Julian Djamil Fagir <gnrp%komkon2.de@localhost>]

The following reply was made to PR install/35538; it has been noted by GNATS.

From: Julian Djamil Fagir <gnrp%komkon2.de@localhost>
To: gnats-bugs%gnats.netbsd.org@localhost
Cc: 
Subject: Re: install/35538: sysinst duplicates hostname on upgrade
Date: Sat, 3 Mar 2012 02:44:44 +0100

 --MP_/wTV/S8aqsHTy7OlJGBl1cG4
 Content-Type: text/plain; charset=US-ASCII
 Content-Transfer-Encoding: 7bit
 Content-Disposition: inline
 
 Hi,
 
 imho, network configuration should not be stored when updating anyway. You
 want to only update the system, not change any of the configuration.
 The attached patch should do so (tbh, untested, but its effect is apparent).
 
 Regards, Julian
 --MP_/wTV/S8aqsHTy7OlJGBl1cG4
 Content-Type: text/x-patch
 Content-Transfer-Encoding: 7bit
 Content-Disposition: attachment; filename=util.c.diff
 
 --- distrib/utils/sysinst/util.c
 +++ distrib/utils/sysinst/util.c
 @@ -1084,11 +1084,12 @@
  
        /* Save keybard type */
        save_kb_encoding();
  
        /* Other configuration. */
 -      mnt_net_config();
 +      if (!update)
 +              mnt_net_config();
  
        /* Mounted dist dir? */
        umount_mnt2();
  
        /* Install/Upgrade complete ... reboot or exit to script */
 
 
 --MP_/wTV/S8aqsHTy7OlJGBl1cG4--