Re: bin/46102 (The banner(1) manpage, as well as the program's `usage' line, could use improvement)

[Bug Hunting <bughunting%xs4all.nl@localhost>]

Hi,

On Sun, Feb 26, 2012 at 09:16:24PM +0000, wiz%NetBSD.org@localhost wrote:
> State-Changed-From-To: open->closed
> [...]
> Committed, thanks :)
Thanks for extending the patch a bit, and applying the end result.

However, some things seemed to go wrong as well: trailing white
space was added to the manpage, the final argument in banner.c's
`usage' line (still) isn't synchronized with the manpage's notation
of it, and a dash (`-') disappeared from that same line,

The patch attached (MD5 sum: c8a1e6dced6895706359e160e2dc2dab)
fixes all this; please apply it.

Thanks,

Bug Hunting

Index: banner.1
===================================================================
RCS file: /cvsroot/src/usr.bin/banner/banner.1,v
retrieving revision 1.8
diff -u -r1.8 banner.1
--- banner.1    26 Feb 2012 21:04:10 -0000      1.8
+++ banner.1    28 Feb 2012 23:03:53 -0000
@@ -57,7 +57,7 @@
 .Nm
 font.
 .El
-.Sh EXIT STATUS                                                                
                                                                                
                                                    
-.Ex -std                                                                       
                                                                                
                                                    
+.Sh EXIT STATUS
+.Ex -std
 .Sh SEE ALSO
 .Xr banner 6
Index: banner.c
===================================================================
RCS file: /cvsroot/src/usr.bin/banner/banner.c,v
retrieving revision 1.14
diff -u -r1.14 banner.c
--- banner.c    26 Feb 2012 21:04:10 -0000      1.14
+++ banner.c    28 Feb 2012 23:03:53 -0000
@@ -205,7 +205,7 @@
 static void
 usage(void)
 {
-    fprintf(stderr, "usage: %s [-l] [b bg] [-f fg] message...\n",
+    fprintf(stderr, "usage: %s [-l] [-b bg] [-f fg] string ...\n",
        getprogname());
     exit(1);
 }