Re: PR/45932 CVS commit: src/sys/dev/ic

[Pierre Pronchery <khorben%defora.org@localhost>]

The following reply was made to PR kern/45932; it has been noted by GNATS.

From: Pierre Pronchery <khorben%defora.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: Christos Zoulas <christos%netbsd.org@localhost>, 
kern-bug-people%netbsd.org@localhost, 
 gnats-admin%netbsd.org@localhost, netbsd-bugs%netbsd.org@localhost
Subject: Re: PR/45932 CVS commit: src/sys/dev/ic
Date: Mon, 06 Feb 2012 04:14:25 +0100

                        Hey Christos,
 
 thanks for committing this - unfortunately I realized that it was not
 enough. Here's maybe the reason why I was confused by the error messages
 from pmf:
 
 Index: sys/dev/isa/tpm_isa.c
 ===================================================================
 RCS file: /cvsroot/src/sys/dev/isa/tpm_isa.c,v
 retrieving revision 1.1
 diff -p -u -r1.1 tpm_isa.c
 --- sys/dev/isa/tpm_isa.c      22 Jan 2012 06:44:28 -0000      1.1
 +++ sys/dev/isa/tpm_isa.c      6 Feb 2012 03:06:30 -0000
 @@ -117,10 +117,11 @@ tpm_isa_attach(device_t parent, device_t
                return;
        }
 
 -          device_xname(sc->sc_dev))) != 0)
 +          device_xname(sc->sc_dev))) != 0) {
                bus_space_unmap(sc->sc_bt, sc->sc_bh, size);
                return;
 +      }
 
        /*
         * Only setup interrupt handler when we have a vector and the
 
 With the brackets missing, attaching was returning prematurely,
 therefore not setting the interrupt handler and obviously, not really
 registering to PMF either.
 
 Now it suspends :)
 
 Cheers,
 -- khorben
 
 On 06/02/2012 03:05, Christos Zoulas wrote:
 > The following reply was made to PR kern/45932; it has been noted by GNATS.
 > 
 > From: "Christos Zoulas" <christos%netbsd.org@localhost>
 > To: gnats-bugs%gnats.NetBSD.org@localhost
 > Cc: 
 > Subject: PR/45932 CVS commit: src/sys/dev/ic
 > Date: Sun, 5 Feb 2012 21:03:32 -0500
 > 
 >  Module Name:        src
 >  Committed By:       christos
 >  Date:               Mon Feb  6 02:03:32 UTC 2012
 >  
 >  Modified Files:
 >      src/sys/dev/ic: tpm.c
 >  
 >  Log Message:
 >  PR/45932: Pierre Pronchery: Fix the return values of the suspend and resume
 >  functions.
 >  
 >  
 >  To generate a diff of this commit:
 >  cvs rdiff -u -r1.6 -r1.7 src/sys/dev/ic/tpm.c
 >  
 >  Please note that diffs are not public domain; they are subject to the
 >  copyright notices on the relevant files.
 >  
 
 
 -- 
 khorben