bin/45894: ipftest core dumps when running tests

[darrenr%NetBSD.org@localhost]

>Number:         45894
>Category:       bin
>Synopsis:       ipftest core dumps when running tests
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Jan 31 09:30:00 +0000 2012
>Originator:     Darren Reed
>Release:        NetBSD 5.99.63
>Description:
For example, from NetBSD's ATF:

Fail: incorrect exit status: 139, expected: 0
stdout:

stderr:
[1]   Done                    echo "block in all" |
      Segmentation fault (core dumped) ipftest -F text ...

>How-To-Repeat:
Run any of the ipfilter tests that blocks a packet.
>Fix:
        Index: fil.c
===================================================================
RCS file: /devel/CVS/IP-Filter/fil.c,v
retrieving revision 2.443.2.36
diff -c -r2.443.2.36 fil.c
*** fil.c       29 Jan 2012 05:30:35 -0000      2.443.2.36
--- fil.c       31 Jan 2012 09:21:48 -0000
***************
*** 3197,3203 ****
--- 3197,3205 ----
        if (!FR_ISPASS(pass)) {
                LBUMP(ipf_stats[out].fr_block);
                if (*mp != NULL) {
+ #ifdef _KERNEL
                        FREE_MB_T(*mp);
+ #endif
                        m = *mp = NULL;

>Unformatted:
 Architecture: i386
 Machine: i386