bin/45690: "atf-report -o xml" can generate malformed XML

[gson%gson.org@localhost (Andreas Gustafsson)]

>Number:         45690
>Category:       bin
>Synopsis:       "atf-report -o xml" can generate malformed XML
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    bin-bug-people
>State:          open
>Class:          sw-bug
>Submitter-Id:   net
>Arrival-Date:   Tue Dec 06 20:05:00 +0000 2011
>Originator:     Andreas Gustafsson
>Release:        NetBSD-current
>Organization:
>Environment:

System: NetBSD
Architecture: i386
Machine: i386
>Description:

When the standard error output of an ATF case test contains bytes that
are not valid UTF-8 encoded text, "atf-report -o xml" generates XML
output that is not accepted as input by xsltproc, causing the
generation of HTML test reports to fail.

>How-To-Repeat:

  ftp 
http://www.gson.org/netbsd/bugs/build.i386-debug/build/2011.10.06.16.03.48/test.tps
  cat test.tps | atf-report -o xml:test.xml
  xsltproc --nonet --novalid /usr/share/xsl/atf/tests-results.xsl test.xml 

This gives the error message:

  test.xml:10896: parser error : Input is not proper UTF-8, indicate encoding !
  Bytes: 0xB9 0xBB 0x22 0x29
  <se>#5  0xbb95b015 in vpanic (fmt=0xbbb916fc "lfs_rescount", ap=0xb67ff8c0 
"X4??
                                                                                
^
  unable to parse test.xml

(in the above error message, two non-ASCII characters have been
replaced with question marks to avoid email encoding issues).

>Fix: