Re: kern/45571: lfs_vnops.c: redundant unlock and lock

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR kern/45571; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: kern/45571: lfs_vnops.c: redundant unlock and lock
Date: Sat, 5 Nov 2011 18:40:05 +0000

 On Sat, Nov 05, 2011 at 01:40:04PM +0000, nakayosh%leto.eonet.ne.jp@localhost 
wrote:
  > @@ -2315,9 +2315,6 @@
  >             busypg = NULL;
  >             if (check_dirty(fs, vp, startoffset, endoffset, blkeof,
  >                             ap->a_flags, 0, &busypg) < 0) {
  > -                   mutex_exit(vp->v_interlock);
  > -
  > -                   mutex_enter(vp->v_interlock);
  >                     write_and_wait(fs, vp, busypg, seglocked, NULL);
  >                     if (!seglocked) {
  >                             mutex_exit(vp->v_interlock);
  > 
 
 Almost certainly... but there's some (probably small) chance that's a
 deliberate hack to avoid some deadlock case, so I'd better look into
 it more closely.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost