Re: bin/45453: add /etc/cron.d functionality

[David Holland <dholland-bugs%netbsd.org@localhost>]

The following reply was made to PR bin/45453; it has been noted by GNATS.

From: David Holland <dholland-bugs%netbsd.org@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: bin/45453: add /etc/cron.d functionality
Date: Fri, 14 Oct 2011 05:23:22 +0000

 On Wed, Oct 12, 2011 at 06:35:02AM +0000, Takahiro Kambe wrote:
  >> +  if ((len > 8) && (strncmp(fname + len - 8, ".rpmsave", 8) == 0))
  >> +          continue;
  >> +  if ((len > 8) && (strncmp(fname + len - 8, ".rpmorig", 8) == 0))
  >> +          continue;
  >> +  if ((len > 7) && (strncmp(fname + len - 7, ".rpmnew", 7) == 0))
  >> +          continue;
  >  We don't hardcode such suffixes but give cron(8) to some excluding
  >  patterns.  (Above is too rpmism, too.)
 
 Rather than blacklist some set of extensions (and as you note, the
 ones it has seem totally wrong) it ought to accept only files named
 e.g. *.cron. Much safer that way.
 
 -- 
 David A. Holland
 dholland%netbsd.org@localhost