Re: toolchain/45396: make clean fails in src/lib/libarch for mips build

[Alan Barrett <apb%cequrux.com@localhost>]

The following reply was made to PR toolchain/45396; it has been noted by GNATS.

From: Alan Barrett <apb%cequrux.com@localhost>
To: gnats-bugs%NetBSD.org@localhost
Cc: 
Subject: Re: toolchain/45396: make clean fails in src/lib/libarch for mips
 build
Date: Fri, 23 Sep 2011 18:18:11 +0200

 On Fri, 23 Sep 2011, Izumi Tsutsui wrote:
 >#   clean CLEANFILES
 >(cd /work/src/lib/libarch && rm -f  )
 >Failed to remove files from /work/src/lib/libarch:
 >.
 
 Please also try this patch, which uses :M* to ignore the difference
 between an empty strig and a string that contains only spaces.
 
 Index: bsd.clean.mk
 --- bsd.clean.mk       10 Sep 2011 19:25:10 -0000      1.2
 +++ bsd.clean.mk       23 Sep 2011 16:14:35 -0000
 @@ -41,14 +41,14 @@ __docleandir:      .PHONY .MADE __cleanuse CL
   # both .OBJDIR and .SRCDIR.
   #
   __cleanuse: .USE
 -      ${"${.ALLSRC:@v@${${v}}@}" == "":?@true:${_MKMSG} \
 -              "clean" ${.ALLSRC} }
 +      ${"${.ALLSRC:@v@${${v}:M*}@}" == "":?@true:${_MKMSG} \
 +              "clean" ${.ALLSRC} ${.ALLSRC:@v@\"${${v}:Q}\"@} }
   .for _d in ${"${.OBJDIR}" == "${.CURDIR}" \
                :? ${.OBJDIR} \
                :  ${.OBJDIR} ${.CURDIR} }
 -      -${"${.ALLSRC:@v@${${v}}@}" == "":?@true: \
 +      -${"${.ALLSRC:@v@${${v}:M*}@}" == "":?@true: \
            (cd ${_d} && rm -f ${.ALLSRC:@v@${${v}}@}) }
 -      @${"${.ALLSRC:@v@${${v}}@}" == "":?true: \
 +      @${"${.ALLSRC:@v@${${v}:M*}@}" == "":?true: \
            bad="\$(cd ${_d} && ls -d ${.ALLSRC:@v@${${v}}@} 2>/dev/null)"; \
            if test -n "\$bad"; then \
                echo "Failed to remove files from ${_d}:" ; \